Skip to content

DOC-4410 added SkipIfRedis test marker and PHP comment style #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

DOC-4410 added SkipIfRedis test marker and PHP comment style #812

merged 1 commit into from
Oct 25, 2024

Conversation

@andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Oct 25, 2024 •
edited by atlassian bot
Loading

DOC-4410

Also added a comment type for PHP, which will soon be required.

@andy-stark-redis andy-stark-redis self-assigned this Oct 25, 2024
dwdougherty
dwdougherty approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other required changes for PHP, but we can cross that bridge when you're ready.

@andy-stark-redis
Copy link
Contributor Author

There are other required changes for PHP, but we can cross that bridge when you're ready.

@dwdougherty Yeah, I think this is going to become one of my jobs for next quarter. Anyway, thanks for the review :-)

@andy-stark-redis andy-stark-redis merged commit 57a76bf into main Oct 25, 2024
4 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-4410-remove-new-csharp-attr branch October 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

Assignees

@andy-stark-redis andy-stark-redis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andy-stark-redis @dwdougherty